Skip to content

[CP Staging] Revert "fix: infinite loading appears when logging in via hellogorgeous link"#78641

Merged
mountiny merged 1 commit into
mainfrom
revert-75808-paulnjs-fix/73506
Dec 31, 2025
Merged

[CP Staging] Revert "fix: infinite loading appears when logging in via hellogorgeous link"#78641
mountiny merged 1 commit into
mainfrom
revert-75808-paulnjs-fix/73506

Conversation

@mountiny

Copy link
Copy Markdown
Contributor

Reverts #75808

Testing #78626

@melvin-bot

melvin-bot Bot commented Dec 31, 2025

Copy link
Copy Markdown

@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #78641.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://78641.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov

codecov Bot commented Dec 31, 2025

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/actions/Link.ts 29.53% <0.00%> (ø)
... and 6 files with indirect coverage changes

@MarioExpensify

Copy link
Copy Markdown
Contributor

Approved, but it seems the bug can still be reproduced.

@mountiny

Copy link
Copy Markdown
Contributor Author

@mountiny mountiny changed the title Revert "fix: infinite loading appears when logging in via hellogorgeous link" [CP Staging] Revert "fix: infinite loading appears when logging in via hellogorgeous link" Dec 31, 2025
@mountiny mountiny merged commit 9d16906 into main Dec 31, 2025
32 of 35 checks passed
@mountiny mountiny deleted the revert-75808-paulnjs-fix/73506 branch December 31, 2025 16:11
@melvin-bot

melvin-bot Bot commented Dec 31, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Dec 31, 2025
@mountiny

Copy link
Copy Markdown
Contributor Author

Straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Dec 31, 2025
(cherry picked from commit 9d16906)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 31, 2025
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.89-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.89-6 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.90-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.90-2 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants